[PATCH] D126442: [LegalizeTypes][VP] Add widen and split support for VP_SIGN_EXTEND and VP_ZERO_EXTEND.
Craig Topper via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed May 25 22:03:13 PDT 2022
craig.topper added inline comments.
================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp:1052
+ case ISD::VP_ZERO_EXTEND:
SplitVecRes_ExtendOp(N, Lo, Hi);
break;
----------------
You should call SplitVecRes_UnaryOp for VP_SIGN_EXTEND/VP_ZERO_EXTEND. There's code in SplitVecRes_ExtendOp that hasn't been updated for VP intrinsics. I'm not sure if it can be exercised or not. But best to avoid it and leave a FIXME.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D126442/new/
https://reviews.llvm.org/D126442
More information about the llvm-commits
mailing list