[PATCH] D126355: [FuncSpec]Fix assertion failure when lattice value is not found.

[Bin Cheng via Phabricator via llvm-commits]

bin.cheng added a comment.

In D126355#3539163 <https://reviews.llvm.org/D126355#3539163>, @sinan wrote:

> In D126355#3536597 <https://reviews.llvm.org/D126355#3536597>, @ChuanqiXu wrote:
>
>> We should generate a patch with option `-U9999` to offer more context to review.
>
> Thanks for the info and feedback. I have updated the diff file.
>
>> Thanks for working on this. Have you measured any performance/code size change?
>
> I only ran on Spec 2017, and luckily no crash during compiling. I will check the performance/code size different later.
>
>> Also, I feel we could do better since we've already mark it as overrefined in https://github.com/llvm/llvm-project/blob/cd2292ef824591cc34cc299910a3098545c840c7/llvm/lib/Transforms/Utils/SCCPSolver.cpp#L1254 
>> So it looks possible to get the lattice successfully.
>
> Ok, I will think about it, thanks again!

Given it might be non-trivial to support ByVal arguments in SCCPSolver, and ByVal is generally used for pointers to structure/array, we can first try to get this version of patch reviewed and merged, then work on ByVal/SCCPSolver as a following task (probably with a lower priority).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126355/new/

https://reviews.llvm.org/D126355