[PATCH] D126425: [llvm-ml] Add support for the .S extension

[Eric Astor via Phabricator via llvm-commits]

epastor accepted this revision.
epastor added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/test/tools/llvm-ml/invalid_file_extension.blah:1
+; RUN: not llvm-ml %s /Fo /dev/null 2>&1 | FileCheck %s
+
----------------
ayzhao wrote:
> epastor wrote:
> > While we're at it, mind testing the /Ta option as well, which is supposed to allow assembly of any file regardless of extension?
> > 
> > I think you can just add another RUN line here using /Ta, and use a different CHECK suffix to distinguish the results.
> Done.
> 
> Incidentally, this exposed a bug in the implementation of `/Ta`, which I fixed.
Thank you!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126425/new/

https://reviews.llvm.org/D126425