[PATCH] D100353: Support optnone in SCCP

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 25 14:50:59 PDT 2022


dblaikie abandoned this revision.
dblaikie added a comment.
Herald added a project: All.

Abandoning this since the discussion ended up pointing towards a preference for a distinct `noipa` attribute. Then that stalled out in discussions about whether that could be implemented via `isInterposable` or would need a separate proprety and then revisiting/restesting every check for interposability to instead test "interposable or noipa", basically... which made me a bit exhausted to think about visiting/changing/retesting all those cases and so I haven't picked this up again. It's over in D101011 <https://reviews.llvm.org/D101011> if anyone wants to weigh in there/pick it up/poke it with a stick, etc.

All rather unfortunate, I think - there's a bunch of evidence that noipa was in a bunch of ways what some people expected from optnone. Pity we didn't get that from the start/weren't willing to accept that as a bugfix, of sorts, but ah well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100353/new/

https://reviews.llvm.org/D100353



More information about the llvm-commits mailing list