[PATCH] D126270: [InstCombine] Preserve !nosanitize for newly created instructions.

[Nikita Popov via Phabricator via llvm-commits]

nikic added a comment.

Compile-time for the new version: https://llvm-compile-time-tracker.com/compare.php?from=3e7285426d979eb1719b88e76b3a63ea78dafb60&to=b8e2e12990da9c34c8bc7a7d52b02e825fbd3877&stat=instructions This is much better than before, though still fairly expensive. I'd suggest landing the MD_nosanitize patch regardless of whether we make this change, as it's clearly beneficial to have a known ID for this.

I haven't looked into the general problem being solved here, but if this is a matter of correctness, then @efriedma's suggestion is probably the right one. Metadata preservation in LLVM is best-effort and dropping metadata should never result in a miscompile (which a sanitizer false positive arguably is).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126270/new/

https://reviews.llvm.org/D126270