[PATCH] D126378: [SLP]Fix crash on reordering of ScatterVectorize nodes.

[Vasileios Porpodas via Phabricator via llvm-commits]

vporpo accepted this revision.
vporpo added a comment.
This revision is now accepted and ready to land.

LG



================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:3813
       Edges.emplace_back(I, TE);
+      if (TE->State != TreeEntry::Vectorize)
+        GatherOps.push_back(TE);
----------------
Please add a comment about when this is expected to happen. If I understand correctly that this is happening for State == TreeEntry::ScatterVectorize. It is a bit confusing that this code is guarded by if (getVectorizedOperand()), so one would expect that TE's state would be `Vectorize`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126378/new/

https://reviews.llvm.org/D126378