[PATCH] D126344: [memprof] Keep and display symbol names in the RawMemProfReader.

[Snehasish Kumar via Phabricator via llvm-commits]

snehasish marked an inline comment as done.
snehasish added a comment.

PTAL, thanks!



================
Comment at: llvm/lib/ProfileData/RawMemProfReader.cpp:419
+        if (KeepSymbolName)
+          GuidToSymbolName.insert({Guid, DIFrame.FunctionName});
 
----------------
tejohnson wrote:
> Why not add the function name into the Frame here rather than waiting for the later call to idToFrame() and filling it from the map then?
The idea here is to save memory by not duplicating the symbol names since we can have many unique frames (a combination of symbol + location). Also the processing does not require the symbol name today, so we only populate it in the iterator interface where a single MemProfRecord object is instantiated at a time.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126344/new/

https://reviews.llvm.org/D126344