[PATCH] D126371: [SLP]Fix PR55688: Miscompile due to incorrect nuw handling.

[Sanjay Patel via Phabricator via llvm-commits]

spatel added a comment.

I don't know if this exercises any different paths, but I added the test that I suggested here:
d3187dd5f0f0 <https://reviews.llvm.org/rGd3187dd5f0f07c9c7536792af25ba723506f6339>
...because other regression tests in these files are not reduced enough to easily verify with Alive2.



================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:10329-10330
 
   /// Creates reduction operation with the current opcode with the IR flags
   /// from \p ReductionOps.
   static Value *createOp(IRBuilder<> &Builder, RecurKind RdxKind, Value *LHS,
----------------
Adjust this description.


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:10355-10356
 
   /// Creates reduction operation with the current opcode with the IR flags
   /// from \p I.
   static Value *createOp(IRBuilder<> &Builder, RecurKind RdxKind, Value *LHS,
----------------
Can this one also cause trouble?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126371/new/

https://reviews.llvm.org/D126371