[PATCH] D114846: [llvm] [Debuginfod] LLVM debuginfod server.

[Peter Collingbourne via Phabricator via llvm-commits]

pcc added inline comments.


================
Comment at: llvm/tools/llvm-debuginfod/llvm-debuginfod.cpp:43
+static cl::opt<double>
+    ScanInterval("t", cl::init(10000),
+                 cl::desc("Number of seconds to wait between subsequent scans "
----------------
phosek wrote:
> 10000s is a long time between scans, elfutils defaults to 300s which I think would be better.
If the server implements the following behavior, do we need a scan interval?

- If the build-id is not found by a local lookup, rescan immediately and look up the build-id again before returning 404.

- To protect against DoS attacks, do not rescan more frequently than once per N seconds (e.g. N = 30).

debuginfod does not have this behavior and it was somewhat of a pain point when using it for local development.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114846/new/

https://reviews.llvm.org/D114846