[PATCH] D125324: AMDGPU/GISel: Factor out AMDGPURegisterBankInfo::buildReadFirstLane

Nicolai Hähnle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 25 09:35:35 PDT 2022


nhaehnle added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPURegisterBankInfo.cpp:1017
   MachineIRBuilder B(MI);
+  B.setDebugLoc(MI.getDebugLoc());
 
----------------
arsenm wrote:
> Doesn't this happen in the constructor? (I do have a patch I Need to pick up to stop reconstructing this in RegBankSelect)
You're right, I removed it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125324/new/

https://reviews.llvm.org/D125324



More information about the llvm-commits mailing list