[PATCH] D125652: [LLVM] Add a check if should cast atomic operations to integer type

[James Y Knight via Phabricator via llvm-commits]

jyknight added subscribers: efriedma, jyknight.
jyknight added a comment.

As somewhat coincidentally just discussed in the thread on https://reviews.llvm.org/D124728 the target hooks don't really make sense as implemented here.

Whether a cast to an integer is required is due in part to what code AtomicExpandPass itself generates (configured based upon existing target hooks), and whether _that_ expansion requires the value to be an integer (almost all of them currently do). Requiring targets to deduce those requirements and encode it into a brand new target hook seems error-prone, and should be avoided.

@efriedma


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125652/new/

https://reviews.llvm.org/D125652