[PATCH] D125296: [VP] vp intrinsics are not speculatable

Simon Moll via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 25 07:10:52 PDT 2022


simoll updated this revision to Diff 431976.
simoll edited the summary of this revision.
simoll added a comment.

VP intrinsics show UB if the %evl parameter is out of bounds - they must not carry the speculatable attribute.  The out-of-bounds UB disappears when the %evl parameter is expanded into the mask or expansion replaces the entire VP intrinsic with non-VP code.

      

This patch

- Removes the speculatable attribute on all VP intrinsics.
- Generalizes the isSafeToSpeculativelyExecute function to let VP expansion know whether the VP intrinsic replacement will be speculatable.  VP expansion may only discard %evl where this is the case.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125296/new/

https://reviews.llvm.org/D125296

Files:
  llvm/include/llvm/Analysis/ValueTracking.h
  llvm/include/llvm/IR/Intrinsics.td
  llvm/lib/Analysis/ValueTracking.cpp
  llvm/lib/CodeGen/ExpandVectorPredication.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D125296.431976.patch
Type: text/x-patch
Size: 31194 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220525/24a1ff87/attachment.bin>


More information about the llvm-commits mailing list