[PATCH] D126344: [memprof] Keep and display symbol names in the RawMemProfReader.

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson added inline comments.


================
Comment at: llvm/include/llvm/ProfileData/MemProf.h:146
+  // The symbol name for the function. Only populated in the Frame by the reader
+  // if requested during initialization. This field should not serialized.
+  llvm::Optional<std::string> SymbolName;
----------------
"should not be serialized" (missing "be")


================
Comment at: llvm/lib/ProfileData/RawMemProfReader.cpp:419
+        if (KeepSymbolName)
+          GuidToSymbolName.insert({Guid, DIFrame.FunctionName});
 
----------------
Why not add the function name into the Frame here rather than waiting for the later call to idToFrame() and filling it from the map then?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126344/new/

https://reviews.llvm.org/D126344