[PATCH] D125847: LTO: Decide upfront whether to use opaque/non-opaque pointer types

[Nikita Popov via Phabricator via llvm-commits]

nikic added a comment.

Looks reasonable to me, but probably @MaskRay should review.

We could add a `-fno-opaque-pointers` driver option that covers both the compiler backend and LTO, but we can probably get away without it as well.



================
Comment at: lld/ELF/Options.td:311
+  "Use opaque pointers in IR used during LTO",
+  "Use typed pointers in IR used during LTO (default)">;
+
----------------
`(default)` here is outdated.

Possibly this option should be `lto_opaque_pointers`? That seems to be the convention for other related options.


================
Comment at: llvm/docs/OpaquePointers.rst:69
+LLVM tools like ``opt``, or ``-Xclang -opaque-pointers`` in clang,
+``-Wl,-plugin-opt=-opaque-pointers`` for LTO. Additionally, opaque pointer mode
+is automatically enabled for IR and bitcode files that use the ``ptr`` type.
----------------
`-plugin-opt=opaque-pointers`. Though it probably makes more sense now to mention this at the end of the document, as an option to //disable//.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125847/new/

https://reviews.llvm.org/D125847