[PATCH] D126366: [llvm-rc] Avoid which(1) dependency in windres-prefix.test

Michał Górny via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 25 04:07:12 PDT 2022


mgorny created this revision.
mgorny added reviewers: mstorsjo, MaskRay.
Herald added a subscriber: StephenFan.
Herald added a project: All.
mgorny requested review of this revision.
Herald added a project: LLVM.

Rely on lit substitution to provide the path to llvm-windres instead
of redundantly calling which(1) with the subtituted absolute path.
This fixes test failure on the happy systems without which(1) installed.


https://reviews.llvm.org/D126366

Files:
  llvm/test/tools/llvm-rc/windres-prefix.test


Index: llvm/test/tools/llvm-rc/windres-prefix.test
===================================================================
--- llvm/test/tools/llvm-rc/windres-prefix.test
+++ llvm/test/tools/llvm-rc/windres-prefix.test
@@ -4,7 +4,7 @@
 
 ; Check that a triple prefix on the executable gets picked up as target triple.
 
-; RUN: ln -fs $(which llvm-windres) %t/aarch64-w64-mingw32-windres
+; RUN: ln -fs llvm-windres %t/aarch64-w64-mingw32-windres
 ; RUN: %t/aarch64-w64-mingw32-windres -### %p/Inputs/empty.rc %t.res | FileCheck %s --check-prefix=CHECK-PREPROC
 ; CHECK-PREPROC: "clang" "--driver-mode=gcc" "-target" "aarch64-w64-mingw32"
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D126366.431935.patch
Type: text/x-patch
Size: 637 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220525/7dbbf070/attachment.bin>


More information about the llvm-commits mailing list