[PATCH] D125029: [VPlan] Exit earlier when trying to widen with scalar VFs.
Florian Hahn via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed May 25 03:10:30 PDT 2022
fhahn marked 2 inline comments as done.
fhahn added inline comments.
================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:8577
}
// Record the incoming value from the backedge, so we can add the incoming
----------------
Ayal wrote:
> Unrelated nits while we're here: above could benefit slightly from condition reversal, below needs its indentation fixed.
I'll fix the indent separately.
> above could benefit slightly from condition reversal,
Do you mean handling the single line case first?
================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:8590
return toVPRecipeResult(Recipe);
+ if (LoopVectorizationPlanner::getDecisionAndClampRange(
----------------
Ayal wrote:
> Would be good to add a comment stating that all other "Widen" recipes from here on deal only with VF>1.
Good point, I added a comment in the committed version.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125029/new/
https://reviews.llvm.org/D125029
More information about the llvm-commits
mailing list