[PATCH] D126355: [FuncSpec]Fix assertion failure when lattice value is not found.

Chuanqi Xu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 25 02:40:08 PDT 2022


ChuanqiXu added a comment.

We should generate a patch with option `-U9999` to offer more context to review.

Thanks for working on this. Have you measured any performance/code size change?

Also, I feel we could do better since we've already mark it as overrefined in https://github.com/llvm/llvm-project/blob/cd2292ef824591cc34cc299910a3098545c840c7/llvm/lib/Transforms/Utils/SCCPSolver.cpp#L1254 
So it looks possible to get the lattice successfully.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126355/new/

https://reviews.llvm.org/D126355



More information about the llvm-commits mailing list