[PATCH] D126040: [InstCombine] Fold a mul with bool value into and

Allen zhong via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 25 01:00:46 PDT 2022


Allen added inline comments.


================
Comment at: llvm/test/Transforms/InstCombine/mul-bool.ll:1-2
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
+; RUN: opt < %s -passes=instcombine -S | FileCheck %s
+
----------------
spatel wrote:
> It would be better to pre-commit these tests with baseline results in the same file as one of the related transforms. Add to "mul-masked-bits.ll" ?
hi @spatel, I try to pre-commit these tests with commit https://reviews.llvm.org/D126356, please help to review, thanks!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126040/new/

https://reviews.llvm.org/D126040



More information about the llvm-commits mailing list