[PATCH] D126343: [libunwind] Use process_vm_readv to avoid potential segfaults

[Fangrui Song via Phabricator via llvm-commits]

MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.

LGTM, but hope @rprichard can verify this.



================
Comment at: libunwind/test/bad_unwind_info.pass.cpp:55
+#else
+#error "This test is only supported for aarch64 or x86-64"
+#endif
----------------
only supported on aarch64 and x86-64.

`#error` does not need a quoted argument.


================
Comment at: libunwind/test/bad_unwind_info.pass.cpp:70
+
+void bad_unwind_info();
+}
----------------
Use `__attribute__((naked))` with basic asm (https://gcc.gnu.org/onlinedocs/gcc/Basic-Asm.html), then get rid of the inline assembly language at file scope.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126343/new/

https://reviews.llvm.org/D126343