[PATCH] D125997: [AMDGPU] Instruction Type Pipeline

[Austin Kerbow via Phabricator via llvm-commits]

kerbowa accepted this revision.
kerbowa added a comment.
This revision is now accepted and ready to land.

As a basis for our planned extensions, this looks OK.

In the future try to comment your code :)



================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUMFMAIGroupLP.cpp:35
+
+static cl::opt<int>
+    VMEMGroupMaxSize("amdgpu-vmem-group-size", cl::init(-1), cl::Hidden,
----------------
Can these options all have the amdgpu-mfma-igrouplp prefix?
In the next iteration of the patch these will be combined correct?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125997/new/

https://reviews.llvm.org/D125997