[PATCH] D126088: [RISCV] Add clarifying asserts to getFrameIndexReference [NFC]

luxufan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 24 22:14:34 PDT 2022


StephenFan added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVFrameLowering.cpp:696
+    // |--------------------------| -- <-- SP
     if (hasBP(MF)) {
       FrameReg = RISCVABI::getBPReg();
----------------
reames wrote:
> StephenFan wrote:
> > Remove the curly bracket?
> We generally prefer consistency between if and else.  The else block requires the bracket.  
Makes sense to me.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126088/new/

https://reviews.llvm.org/D126088



More information about the llvm-commits mailing list