[PATCH] D124612: [AArch64][LV] AArch64 does not prefer vectorized addressing

Tue May 24 21:34:58 PDT 2022

TiehuZhang added a comment.

In D124612#3486176 <https://reviews.llvm.org/D124612#3486176>, @dmgreen wrote:

> Yes - do you have benchmarking results for this patch? This option makes sense, but I'm not sure what it's doing is always optimal. There's something going on with how it alters interleaving group costs, that doesn't look like it should be related to vector addresses. One such case was cleaned up (or maybe hidden) by D124786 <https://reviews.llvm.org/D124786>, but more problems might be present.

Hi, @dmgreen, thanks for the comment! 
In fact, this patch is an optimization for 505.lbm_t in spec hpc.

spec hpc

| items     | base(s) | D124612 <https://reviews.llvm.org/D124612>   | affect(%) |
| --------- | ------- | --- | --------- |
| 505.lbm_t | 792     | 673 | 17.7      |
|

I also test spec2017 on llvm-testsuit-main, and the results doesn't show much impact overall. Do you think these statistics can assess the impact of this patch?

CFP2017rate

| items                                | base(s)  | D124612 <https://reviews.llvm.org/D124612>        | affect(%) |
| ------------------------------------ | -------- | -------- | --------- |
| 554.roms_r/554.roms_r.test           | 289.4838 | 283.622  | 2.06676492       |
| 526.blender_r/526.blender_r.test     | 197.1358 | 195.0169 | 1.086521219       |
| 544.nab_r/544.nab_r.test             | 157.0759 | 156.4937 | 0.372027756       |
| 521.wrf_r/521.wrf_r.test             | 100.7203 | 101.583  | -0.849256273      |
| 510.parest_r/510.parest_r.test       | 70.1389  | 70.5425  | -0.572137364      |
| 503.bwaves_r/503.bwaves_r.test       | 80.3388  | 81.0353  | -0.85950197      |
| 549.fotonik3d_r/549.fotonik3d_r.test | 66.388   | 63.7539  | 4.131668808       |
| 538.imagick_r/538.imagick_r.test     | 53.5874  | 53.5616  | 0.048168837       |
| 527.cam4_r/527.cam4_r.test           | 61.1036  | 61.2236  | -0.196002849      |
| 508.namd_r/508.namd_r.test           | 40.3674  | 40.622   | -0.626753976      |
| 519.lbm_r/519.lbm_r.test             | 37.726   | 37.8211  | -0.251446944      |
| 507.cactuBSSN_r/507.cactuBSSN_r.test | 35.404   | 35.3594  | 0.126133362       |
| 511.povray_r/511.povray_r.test       | 5.9146   | 5.9722   | -0.964468705      |
|

CINT2017rate

| items                                | base(s) | D124612 <https://reviews.llvm.org/D124612>       | affect(%) |
| ------------------------------------ | ------- | ------- | --------- |
| 520.omnetpp_r/520.omnetpp_r.test     | 90.2297 | 89.7905 | 0.489138606       |
| 541.leela_r/541.leela_r.test         | 89.2462 | 89.6644 | -0.466405842      |
| 505.mcf_r/505.mcf_r.test             | 84.7131 | 83.7455 | 1.155405365       |
| 531.deepsjeng_r/531.deepsjeng_r.test | 64.9424 | 65.4395 | -0.759632943      |
| 523.xalancbmk_r/523.xalancbmk_r.test | 63.8734 | 63.4812 | 0.617820709       |
| 502.gcc_r/502.gcc_r.test             | 57.0005 | 57.1864 | -0.325077291      |
| 557.xz_r/557.xz_r.test               | 43.8289 | 43.9124 | -0.190151301      |
| 548.exchange2_r/548.exchange2_r.test | 40.916  | 40.3618 | 1.373080487       |
| 500.perlbench_r/500.perlbench_r.test | 27.7047 | 27.802  | -0.349974822      |
| 525.x264_r/525.x264_r.test           | 22.1032 | 22.199  | -0.431550971      |
|

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124612/new/

https://reviews.llvm.org/D124612