[PATCH] D126205: [PowerPC] use BL without nop for some internal calls for fast-isel.

Tue May 24 20:30:39 PDT 2022

shchenz added a comment.

In D126205#3535827 <https://reviews.llvm.org/D126205#3535827>, @nemanjai wrote:

> The more analysis we do in FastISel, the less "fast" it becomes. And the tradeoff here is simply a `nop` after a call which hardly seems like a concern at `-O0`.

I am fine to abandon this.

But see the touched lines `FIXME: We can and should optimize away the NOP for local calls.`. And I tested other compilers like xlc/gcc on PowerPC, they are both not generating `nop` for O0. The `nop` may also have impact to the linker?

@umesh.kalappa0 are you OK we abandon this patch and cancel the PR https://github.com/llvm/llvm-project/issues/55607?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126205/new/

https://reviews.llvm.org/D126205