[PATCH] D125950: [LegalizeTypes][VP] Add widen and split support for VP_TRUNCATE

[WangLian via Phabricator via llvm-commits]

Jimerlife added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp:2912
     ReplaceValueWith(SDValue(N, 1), Ch);
+  } else if (N->getOpcode() == ISD::VP_TRUNCATE) {
+    SDValue MaskLo, MaskHi, EVLLo, EVLHi;
----------------
craig.topper wrote:
> Check the operand count instead of the opcode? Then assert isVPOpcode like the widening code.
I agree with you. Then there is more general.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125950/new/

https://reviews.llvm.org/D125950