[PATCH] D126203: [PowerPC] make callsShareTOCBase be a member function. NFC

Nemanja Ivanovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 24 16:34:02 PDT 2022


nemanjai added a comment.

This seems like a rather invasive refactoring for removing a `nop` at `-O0`. I am not particularly in favour of this. Not only is a `nop` essentially trivial when it comes to performance (and even code size), but this is restricted to unoptimized code gen for which it isn't really reasonable to expect performant code.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126203/new/

https://reviews.llvm.org/D126203



More information about the llvm-commits mailing list