[PATCH] D125611: DWARFVerifier: Change vector of IntervalMap to vector of unique_ptrs

[David Blaikie via Phabricator via llvm-commits]

dblaikie added a comment.

Looking at D125899 <https://reviews.llvm.org/D125899> in more detail I'm OK with deciding that adding good quality copy/move semantics to IntervalMap is a bigger project than I'm up for right now & so let's go with this direction instead (sorry for the back and forth - thanks for understanding).

If you want to submit a follow-up patch to disable copy/move (construction and assignment) for IntervalMap, that'd be great, otherwise I can do that once this lands.



================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFVerifier.cpp:426
+        Sections[Col] = std::make_unique<MapType>(Alloc);
       auto &M = Sections[Col];
+      auto I = M->find(SC.Offset);
----------------
Perhaps this could be:
```
auto &M = *Sections[Col];
```
To keep the rest of the code simpler/without having to add a few `->`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125611/new/

https://reviews.llvm.org/D125611