[PATCH] D124869: [RISCV] Hoist VSETVLI out of idiomatic fixed length vector loops

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 24 14:11:12 PDT 2022


craig.topper added a comment.

LGTM. Other than that last comment.



================
Comment at: llvm/lib/Target/RISCV/RISCVInsertVSETVLI.cpp:1371
+  // or modify VL or VTYPE.  Also, fallthrough will return end().
+  auto InsertPt = UnavailablePred->getFirstTerminator().getInstrIterator();
+  insertVSETVLI(*UnavailablePred, InsertPt,
----------------
Can this use getFirstInstrTerminator()?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124869/new/

https://reviews.llvm.org/D124869



More information about the llvm-commits mailing list