[PATCH] D95137: [update_(llc_)test_checks.py] Support pre-processing commands

Alexander Richardson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 24 13:38:38 PDT 2022


arichardson added a comment.

Unless there are any

In D95137#3517661 <https://reviews.llvm.org/D95137#3517661>, @rtereshin wrote:

> Hi,
>
> Doesn't look like this just handles `--llc-binary` command line argument of update_llc_test_checks.py correctly: I assume references to `llc` from within the `preprocess_cmd` should also be replaced with the value of `--llc-binary` if any, similarly to the substitution done for the main part of the command?
>
> Thanks!

Yes that would be ideal (and shouldn't be too hard to implement), I just never had the need for that so far.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95137/new/

https://reviews.llvm.org/D95137



More information about the llvm-commits mailing list