[PATCH] D126317: [RISCV] Add an operand kind to the opcode/imm returned from RISCVMatInt.

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 24 13:27:39 PDT 2022


reames added a comment.

I want to suggest an alternate, and possibly simpler change.

Instead of adding a field to Inst, what if we added a helper routine instead which just did the switch on opcode internally and returned the Kind?  The client code would look largely the same, but without needing to explicitly track the kind of each opcode at the construction site.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126317/new/

https://reviews.llvm.org/D126317



More information about the llvm-commits mailing list