[PATCH] D124984: [LoopCacheAnalysis] Use smaller numbers when calculating the costs (PR55233)

Bardia Mahjour via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 24 12:56:31 PDT 2022


bmahjour added a comment.

In D124984#3534886 <https://reviews.llvm.org/D124984#3534886>, @congzhe wrote:

> Hi Bardia @bmahjour, after some thoughts I think regarding this patch we would chase a longer-term solution. For now I think I could rework and change this patch (both title and content) to an NFC patch that only updates the test cases, i.e., from using `CHECK` to `CHECK-NEXT`, since we really want to make sure that the output is ordered and the order is correct. I'm wondering how you think about it?

Yes, I agree a long term solution (eg of using double type) would be better. Updating the checks to expect the exact order seems like a good idea to me. Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124984/new/

https://reviews.llvm.org/D124984



More information about the llvm-commits mailing list