[PATCH] D126250: [CodeGen][AArch64] Add support for LDAPR

David Li via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 24 12:11:49 PDT 2022


davidxl added a comment.

In D126250#3534602 <https://reviews.llvm.org/D126250#3534602>, @ktkachov wrote:

> Could you share more details about the performance improvements that motivate this change (what type of workloads, what platforms)?
> One of my concerns is the interoperability with atomics compiled without +rcpc (so using the baseline LDAR). Concurrency bugs resulting from this are usually very tough to track down so it'd be good to see a somewhat formalised argument (maybe with a litmus test?) that this relaxation is correct.

We've seen some network benchmarks improving up to 65% with manual source changes. To test this at scale, we need the compiler changes ready. Perhaps  guard this change with an internal option first?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126250/new/

https://reviews.llvm.org/D126250



More information about the llvm-commits mailing list