[PATCH] D126183: Implement soft reset of the diagnostics engine.

[Richard Smith - zygoloid via Phabricator via llvm-commits]

rsmith added a comment.

I don't think we can live with the `#define private public` approach, not least because this violates the ODR and might lead to compile failures using modules as a result. As an alternative, how about:

- Adding a `friend void DiagnosticTestHelper();` declaration to `DiagnosicsEngine`
- Defining that function in `DiagnosticTest.cpp` and calling it to do your checks of the diagnostics engine's state.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126183/new/

https://reviews.llvm.org/D126183