[PATCH] D122270: Support converting pointers from opaque to typed

Pete Cooper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 24 10:00:57 PDT 2022


pete added a comment.

This looks good to me.

Only thing I can think to add is a test for non-zero address spaces. So probably the gep/load/store tests you have already but an address space of 1 (or any address space that makes sense in DXIL, not sure if any are special).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122270/new/

https://reviews.llvm.org/D122270



More information about the llvm-commits mailing list