[PATCH] D123087: tests: add attributes that would normally come from inferattrs

Augie Fackler via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 24 09:47:34 PDT 2022


durin42 added a comment.

In D123087#3522318 <https://reviews.llvm.org/D123087#3522318>, @nikic wrote:

> I think the general preference would be to explicitly add necessary attributes to test cases, rather than running `inferattrs`. In some of these cases it's not clear to me why the test would need extra attributes, e.g. in case of llvm/test/Transforms/MemCpyOpt/memcpy.ll -- it does test `@malloc`, but I don't think it needs anything beyond the `noalias` attribute that's already present.

Done. A couple of variants of some tests became nonsense (as mentioned in the log message) but for the most part this was straightforward. PTAL?

(This also now comes later in the series, since it has to happen after allockind() exists.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123087/new/

https://reviews.llvm.org/D123087



More information about the llvm-commits mailing list