[PATCH] D126060: [RISCV] Add basic cost modelling for fixed length vector arithmetic

Liao Chunyu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 24 00:21:34 PDT 2022


liaolucy added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVTargetTransformInfo.cpp:236
+    std::pair<InstructionCost, MVT> LT = TLI->getTypeLegalizationCost(DL, Ty);
+    return LT.first + BaseCost;
+  }
----------------
craig.topper wrote:
> LT.first is usually a multiplier. Why is this addition?
I'm still not sure it's accurate. Maybe the integer type needs to return LT.first.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126060/new/

https://reviews.llvm.org/D126060



More information about the llvm-commits mailing list