[PATCH] D123995: [MachineSink] replace MachineLoop with MachineCycle

Mon May 23 21:15:13 PDT 2022

shchenz added a comment.

In D123995#3533225 <https://reviews.llvm.org/D123995#3533225>, @sameerds wrote:

> LGTM! My sincere apologies for the delay ... I have no excuse :(

It doesn't matter at all : )

Thanks very much for review! @sameerds @MatzeB

================
Comment at: llvm/include/llvm/CodeGen/MachineCycleAnalysis.h:45
+
+  // TODO: verify analysis
+};
----------------
MatzeB wrote:
> shchenz wrote:
> > MatzeB wrote:
> > > Do we need a `TODO` comment here? Will the verify analysis added at this particular line?
> > Moved from `lib/CodeGen/MachineCycleAnalysis.cpp`. I thought, it is a placeholder for a declare of verify function?
> Can you just remove it?
Sure, will remove this in the commit.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123995/new/

https://reviews.llvm.org/D123995