[PATCH] D126254: Add support for decoding base64.

[Alexander Shaposhnikov via Phabricator via llvm-commits]

alexander-shaposhnikov added inline comments.


================
Comment at: llvm/include/llvm/Support/Base64.h:58
+llvm::Error decodeBase64(llvm::StringRef Bytes, OutputBytes &Output) {
+  constexpr char DecodeTable[] = {
+      -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1,
----------------
clayborg wrote:
> alexander-shaposhnikov wrote:
> > https://godbolt.org/z/1rqe19MPM vs https://godbolt.org/z/sa1z6M8xf (although this for GCC)
> > -1 -> char  - i guess this might trigger -Wnarrowing
> > 
> Is there a suffix I need to add to the "-1"?
unfortunately i don't know off the top of my head


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126254/new/

https://reviews.llvm.org/D126254