[PATCH] D126207: [AMDGPU][MC][GFX11] Support base+soffset+offset SMEM loads.

Dmitry Preobrazhensky via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 23 14:59:02 PDT 2022


dp added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SMInstructions.td:1145
+    op, ps#"_SGPR_IMM", opName, (ins SReg_32:$soffset, smem_offset_mod:$offset)>;
+  def : MnemonicAlias<!cast<SM_Pseudo>(ps#"_COMMON").Mnemonic, opName>,
+                      Requires<[isGFX11Plus]>;
----------------
Is the _COMMON variant defined for aesthetic reasons? I believe the following code should work:

    def : MnemonicAlias<!cast<SM_Load_Pseudo>(ps#"_IMM").Mnemonic, opName>,



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126207/new/

https://reviews.llvm.org/D126207



More information about the llvm-commits mailing list