[PATCH] D126107: [lld][WebAssembly] Allow first thread to use static TLS region

Thomas Lively via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 23 14:56:59 PDT 2022


tlively accepted this revision.
tlively added a comment.
This revision is now accepted and ready to land.

Thanks, this makes more sense now. LGTM with fixes and extra information in that comment.

Also, in the third paragraph of the description:

"This means that the runtime //and//" => "This means that the runtime //can//"



================
Comment at: lld/wasm/Writer.cpp:1195
+          if (config->isPic) {
+            // Cache the result of the addionion in local 0
+            writeU8(os, WASM_OPCODE_LOCAL_TEE, "local.tee");
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126107/new/

https://reviews.llvm.org/D126107



More information about the llvm-commits mailing list