[llvm] 40b9a26 - emitStringLiteralDef: Return earlier here. NFC.

NAKAMURA Takumi via llvm-commits llvm-commits at lists.llvm.org
Mon May 23 14:03:33 PDT 2022


Author: NAKAMURA Takumi
Date: 2022-05-24T06:02:16+09:00
New Revision: 40b9a2616e459ce271fe14aedd915cc841021dd7

URL: https://github.com/llvm/llvm-project/commit/40b9a2616e459ce271fe14aedd915cc841021dd7
DIFF: https://github.com/llvm/llvm-project/commit/40b9a2616e459ce271fe14aedd915cc841021dd7.diff

LOG: emitStringLiteralDef: Return earlier here. NFC.

Differential Revision: https://reviews.llvm.org/D126135

Added: 
    

Modified: 
    llvm/utils/TableGen/SequenceToOffsetTable.h

Removed: 
    


################################################################################
diff  --git a/llvm/utils/TableGen/SequenceToOffsetTable.h b/llvm/utils/TableGen/SequenceToOffsetTable.h
index 41cdefdb19498..a3d1e185cb2c9 100644
--- a/llvm/utils/TableGen/SequenceToOffsetTable.h
+++ b/llvm/utils/TableGen/SequenceToOffsetTable.h
@@ -170,18 +170,18 @@ class SequenceToOffsetTable {
   /// `EmitLongStrLiterals` is false
   void emitStringLiteralDef(raw_ostream &OS, const llvm::Twine &Decl) const {
     assert(Entries && "Call layout() before emitStringLiteralDef()");
-    if (EmitLongStrLiterals) {
-      OS << "\n#ifdef __GNUC__\n"
-         << "#pragma GCC diagnostic push\n"
-         << "#pragma GCC diagnostic ignored \"-Woverlength-strings\"\n"
-         << "#endif\n"
-         << Decl << " = {\n";
-    } else {
+    if (!EmitLongStrLiterals) {
       OS << Decl << " = {\n";
       emit(OS, printChar, "0");
       OS << "\n};\n\n";
       return;
     }
+
+    OS << "\n#ifdef __GNUC__\n"
+       << "#pragma GCC diagnostic push\n"
+       << "#pragma GCC diagnostic ignored \"-Woverlength-strings\"\n"
+       << "#endif\n"
+       << Decl << " = {\n";
     for (auto I : Seqs) {
       OS << "  /* " << I.second << " */ \"";
       for (auto C : I.first) {


        


More information about the llvm-commits mailing list