[PATCH] D126101: [MCDisassembler] Fix MCSymbolizer::tryAddingSymbolicOperand() interface

Maksim Panchenko via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 23 13:04:05 PDT 2022


maksfb marked 8 inline comments as done.
maksfb added a comment.

Thank you for the review.



================
Comment at: llvm/unittests/MC/X86/X86MCDisassemblerTest.cpp:127
+  checkOperand(0, /*next instr address*/ 11 - /*disp*/ 1, 3, 4);
+  checkOperand(1, 0xffffffffffffefe8, 7, 4);
+
----------------
MaskRay wrote:
> Additionally test `InstSize`
`InstSize` is checked in `checkBytes()`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126101/new/

https://reviews.llvm.org/D126101



More information about the llvm-commits mailing list