[PATCH] D122930: [Propeller] Promote functions with propeller profiles to .text.hot.

Han Shen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 23 10:37:41 PDT 2022


shenhan added a comment.

LGTM



================
Comment at: llvm/lib/CodeGen/CodeGenPrepare.cpp:192
+    "bbsections-guided-section-prefix", cl::Hidden, cl::init(true),
+    cl::desc("Use the basic-block-sections profile to determine the text section prefix for hot functions. Functions with basic-block-sections profile will be placed `.text.hot` regardless of their FDO profile info. Other functions won't be impacted."));
+
----------------
Maybe add more details in help message -  "Other functions won't be impacted, i.e., their prefixes are decided by FDO/AutoFDO profile."


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122930/new/

https://reviews.llvm.org/D122930



More information about the llvm-commits mailing list