[PATCH] D125787: [RISCV] Fix RVV stack frame alignment bugs

[Fraser Cormack via Phabricator via llvm-commits]

frasercrmck added a comment.

In D125787#3531829 <https://reviews.llvm.org/D125787#3531829>, @reames wrote:

> I prototyped this structure, and all of the tests in tree continued to pass.
>
> Given this change has been LGTMed, this is not a blocker, but I think this code organization does make sense as a post cleanup.
>
> I am not particular confident in the correctness of this code as it stands.  Either the existing code, or this patch.

Sorry, forgot to reply. The change you propose makes sense to me logically. I can't tell if there are gotchas in reorganizing things like that though.

Since I think discussions have been across various patches at this point, which aspect of this patch are you suspicious of?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125787/new/

https://reviews.llvm.org/D125787