[PATCH] D123286: [Clang][OpenMP] Support for omp nothing

[Sunil K via Phabricator via llvm-commits]

koops added a comment.



In D123286#3527374 <https://reviews.llvm.org/D123286#3527374>, @koops wrote:

> In D123286#3513797 <https://reviews.llvm.org/D123286#3513797>, @tianshilei1992 wrote:
>
>> Can we have test for right usage?
>
> I do not understand "test for right usage". From the specifications the only right usage for "omp nothing" will be in the metadirective. If you have meeting notes when "omp nothing" was framed please share it.

In gcc sources support "#pragma omp nothing" has been implemented. Test cases for it are in:

gcc/gcc/testsuite/c-c++-common/gomp/nothing-1.c
gcc/gcc/testsuite/c-c++-common/gomp/nothing-2.c

These 2 test cases indicate a similar kind of test cases as those which have been added in this support for "omp nothing". There does not seem to be a  test for right usage.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123286/new/

https://reviews.llvm.org/D123286