[PATCH] D85838: New TableGen Programmer's Reference document
Ivan Kosarev via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon May 23 07:38:43 PDT 2022
kosarev added inline comments.
================
Comment at: llvm/docs/TableGen/ProgRef.rst:197
+.. warning::
+ The ``field`` reserved word is deprecated.
+
----------------
Paul-C-Anagnostopoulos wrote:
> kosarev wrote:
> > How do we know that? There are some mentions of deprecated features in the code, but `field` doesn't seem to be amongst them. Also, the instruction decoder backend looks at the `field` mark to distinct encoding field definitions from ordinary TableGen class fields which is something we seem to rely on in our instruction definition .td's. If `field` is deprecated, then what's supposed to be a replacement for this use case?
> We were hoping that no one would need to use it in the future, which is why it is flagged as deprecated. At some point I am supposed to try to figure out what to do about the current uses.
So if for the current uses there is no alternative and as of today little we can do to avoid using `field` there, then what is the purpose of officially declaring it deprecated? Wouldn't it save us some concerns and confusion to postpone such a declaration until we have a better solution?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85838/new/
https://reviews.llvm.org/D85838
More information about the llvm-commits
mailing list