[PATCH] D124511: [Dexter] Allow Dexter watch commands to specify a range of acceptable FP values

Orlando Cazalet-Hyams via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 23 04:50:57 PDT 2022


Orlando added inline comments.


================
Comment at: cross-project-tests/debuginfo-tests/dexter/dex/utils/Exceptions.py:59
+    """IF a command instruction has the float_range arg but at least one of
+    it's expected values cannot be converted to a float."""
+
----------------
Orlando wrote:
> nit: IF -> if and it's -> its
If* and while you're there, removing "instruction" from that sentence works better IMO.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124511/new/

https://reviews.llvm.org/D124511



More information about the llvm-commits mailing list