[PATCH] D124511: [Dexter] Allow Dexter watch commands to specify a range of acceptable FP values

Stephen Tozer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 23 03:04:55 PDT 2022


StephenTozer added inline comments.


================
Comment at: cross-project-tests/debuginfo-tests/dexter/dex/command/commands/DexExpectWatchBase.py:183
 
+        expected_value = self._maybe_fix_float(step_info.expected_value)
+
----------------
Orlando wrote:
> It's been a little while since I've looked in this code, am I reading this right - `expected_value` is the value returned by the debugger?
Correct, I think the etymology is that it refers to the field of the watch value that we're expecting, i.e. the "value that we have an expectation for". (I do think it's confusing.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124511/new/

https://reviews.llvm.org/D124511



More information about the llvm-commits mailing list