[PATCH] D126185: [RISCV]Remove solved TODO for combining constant shifts

Haocong Lu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 23 00:19:02 PDT 2022


Luhaocong created this revision.
Luhaocong added reviewers: craig.topper, asb, benshi001.
Herald added subscribers: sunshaoce, VincentWu, luke957, StephenFan, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosHD, sabuasal, simoncook, johnrusso, rbar, arichardson.
Herald added a project: All.
Luhaocong requested review of this revision.
Herald added subscribers: llvm-commits, pcwang-thead, eopXD, jacquesguan, MaskRay.
Herald added a project: LLVM.

The constant shifts have be combined, so remove TODO.


https://reviews.llvm.org/D126185

Files:
  llvm/test/CodeGen/RISCV/rv64i-exhaustive-w-insts.ll


Index: llvm/test/CodeGen/RISCV/rv64i-exhaustive-w-insts.ll
===================================================================
--- llvm/test/CodeGen/RISCV/rv64i-exhaustive-w-insts.ll
+++ llvm/test/CodeGen/RISCV/rv64i-exhaustive-w-insts.ll
@@ -1763,8 +1763,6 @@
   ret i32 %1
 }
 
-; TODO: the constant shifts could be combined.
-
 define zeroext i32 @zext_slliw_aext(i32 %a) nounwind {
 ; RV64-LABEL: zext_slliw_aext:
 ; RV64:       # %bb.0:


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D126185.431293.patch
Type: text/x-patch
Size: 442 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220523/0d6c6cc7/attachment.bin>


More information about the llvm-commits mailing list