[PATCH] D124217: [AMDGPU] Allow finer grain control of an unaligned access speed

[Stanislav Mekhanoshin via Phabricator via llvm-commits]

rampitec added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:17017
     // 1. Check the alignment / fast memory access constraint.
-    bool IsFast = false;
+    unsigned IsFast = 0;
     if (!TLI.allowsMemoryAccess(*DAG->getContext(), DAG->getDataLayout(), ResVT,
----------------
kosarev wrote:
> Shouldn't we also rename them all to something like `Fastness`?
I have a change like this. It is 4 times bigger, so I dropped it. We can rename it if this is reasonable, but probably as a separate NFC. In any way it is almost not reviewable.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124217/new/

https://reviews.llvm.org/D124217