[PATCH] D124654: [AIX] Handling the label alignment of a global variable with its multiple aliases.

ChenZheng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun May 22 19:39:19 PDT 2022


shchenz added inline comments.


================
Comment at: llvm/test/CodeGen/PowerPC/aix-alias.ll:87
+; ASM-NEXT:    .vbyte  {{[0-9]+}}, var
+; ASM-NEXT:    .vbyte  {{[0-9]+}}, var1
+; ASM-NEXT:    .globl  var1
----------------
These two `.vbyte` seems regression to me. Now we request more space in `.data` section than needed.


================
Comment at: llvm/test/CodeGen/PowerPC/aix-alias.ll:102
 ; ASM-NEXT:    .vbyte  {{[0-9]+}}, array+4
+; ASM-NEXT:    .vbyte  {{[0-9]+}}, x
+; ASM-NEXT:    .globl  bitcast_alias
----------------
Same like above. We don't need this `.vbyte`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124654/new/

https://reviews.llvm.org/D124654



More information about the llvm-commits mailing list